Adar Dembo has posted comments on this change. Change subject: [java-client] Update protoc and simplify the maven build ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6846/2/java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java File java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java: Line 60: pb.setLowerBound(ByteString.copyFrom(this.lowerBound)); So how come we have to copy these now? http://gerrit.cloudera.org:8080/#/c/6846/2/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java: Line 264: // TODO: we could implement a ZeroCopy approach here by subclassing LiteralByteString. Not sure the comment really makes as much sense now as it did before (since before it was implied that ZeroCopyLiteralByteString subclasses LiteralByteString, and UnsafeByteOperations doesn't do that). http://gerrit.cloudera.org:8080/#/c/6846/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java: Line 26: import org.apache.kudu.PbUtil; What's this for? -- To view, visit http://gerrit.cloudera.org:8080/6846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f7ad260777d5355497fa7e9a1047c342ff9ee9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
