Todd Lipcon has posted comments on this change. Change subject: [java-client] Update protoc and simplify the maven build ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6846/4/java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java: Line 235: return value.toByteArray(); this is resulting in a copy where it wasn't before. I'm a little nervous about the perf here, but maybe not a big deal since scan results are using sidecars? -- To view, visit http://gerrit.cloudera.org:8080/6846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f7ad260777d5355497fa7e9a1047c342ff9ee9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
