Mike Percy has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6850/5//COMMIT_MSG Commit Message: Line 12: DeltaTracker::EstimateOnDiskSizeForCompaction() that > this got renamed in the latest rev? Yeah, renamed to EstimateRedoDeltaOnDiskSize() Also yeah, for Git the typical wrap length is 72 chars per https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting http://gerrit.cloudera.org:8080/#/c/6850/5/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: Line 692: return base_data_->EstimateOnDiskSize() + delta_tracker_->EstimateOnDiskSize(); > since this now includes the UNDO deltas, whereas before it didn't, will thi The major delta compaction estimate is below on L742 which now calls into L683 here so this looks right to me. I searched the code base for other uses of EstimateOnDiskSize() and I didn't find anything that could affect compaction policy. -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
