Todd Lipcon has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size ......................................................................
Patch Set 5: Code-Review-1 (2 comments) http://gerrit.cloudera.org:8080/#/c/6850/5//COMMIT_MSG Commit Message: Line 12: DeltaTracker::EstimateOnDiskSizeForCompaction() that this got renamed in the latest rev? nit: can you re-wrap this paragraph? seems like it's wrapped really small http://gerrit.cloudera.org:8080/#/c/6850/5/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: Line 692: return base_data_->EstimateOnDiskSize() + delta_tracker_->EstimateOnDiskSize(); since this now includes the UNDO deltas, whereas before it didn't, will this have a potential effect on compaction policy? We need to be quite careful with such a change to make sure it doesn't have unintended consequences. (eg what if a DRS including its undos is now larger than the whole compaction budget, but those UNDOs are non-GCable?) -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
