Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/6772/5/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: Line 70: const Schema& schema, > warning: parameter 'tablet_id' is unused [misc-unused-parameters] Expected Line 71: const ChecksumOptions& options, > warning: parameter 'schema' is unused [misc-unused-parameters] Expected Line 242: Status RunKsck() { > warning: non-const reference parameter 'replicas', make it const or use a p Done http://gerrit.cloudera.org:8080/#/c/6772/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 798: } // namespace kudu > error: cannot initialize a parameter of type 'FILE *' (aka '_IO_FILE *') wi Done Line 798: } // namespace kudu > error: use of undeclared identifier 'setw'; did you mean 'getw'? [clang-dia Done Line 798: } // namespace kudu > error: use of undeclared identifier 'setw'; did you mean 'getw'? [clang-dia Done http://gerrit.cloudera.org:8080/#/c/6772/5/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: Line 104: return term_; > warning: value argument 'opid_index' can be moved to avoid copy [misc-move- Done http://gerrit.cloudera.org:8080/#/c/6772/5/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 115: using kudu::consensus::LeaderStepDownResponsePB; > warning: using decl 'RaftConfigPB' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
