Todd Lipcon has posted comments on this change.
Change subject: [WIP] KUDU-1860: ksck doesn't identify tablets that are evicted
but still in config
......................................................................
Patch Set 4:
Just passing through, haven't looked at the code yet, but one thought: to make
the output more readable, maybe we can assign a letter or number to each of the
peers in a config? Something like:
WARNING: Some replicas' configs differ from the master's.
The master's config is:
4414b7f80f4d488eb65e7772759f2bcf (A)
9e8acf07e76c468eadaf1903e923a86a (B) [LEADER]
ac2de1a8f62542fcb7a180dc232b1c30 (C)
The following replicas' configs disagree with the master's or could not be
retrieved:
Replica 9e8acf07e76c468eadaf1903e923a86a (B) with config
9e8acf07e76c468eadaf1903e923a86a (B) [LEADER]
ac2de1a8f62542fcb7a180dc232b1c30 (C)
Replica 4414b7f80f4d488eb65e7772759f2bcf (A) did not return a config
Replica ac2de1a8f62542fcb7a180dc232b1c30 (C) did not return a config
should make it a bit easier to read at a glance
--
To view, visit http://gerrit.cloudera.org:8080/6772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: No
