Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/integration-tests/client_failover-itest.cc File src/kudu/integration-tests/client_failover-itest.cc: PS4, Line 252: tserver::TabletServerIntegrationTestBase why not ExternalMiniClusterITestBase? I'm trying to standardize on that one for ExternalMiniCluster tests http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 167: // A note regarding ServerPicker::MarkServerFailed() calls in this method: I know I mentioned adding a comment but I was thinking just a 2- or 3-line comment in the header file for the declaration of MarkServerFailed. PS4, Line 195: MarkServerFailed Should we rename this method to MarkReplicaFailed for clarity? -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfcece485e4053d921ffdc865612b3e7b9a992a3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
