Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 167: // A note regarding ServerPicker::MarkServerFailed() calls in this method: > The MarkServerFailed signature in ServerPicker assumes it can mark the whol Isn't that just an abstract base class with no other implementations? Can we just redefine the semantics? PS4, Line 195: MarkServerFailed > I'm not sure about this: from the semantics of the error code SERVER_NOT_AC Maybe the confusion we've had about this is that the abstraction here is too general for the problem domain. Maybe it's fine for the server picker to conceptually know about replicas. If you disagree then we can leave it as-is, just trying to think of ways to make it more understandable. -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfcece485e4053d921ffdc865612b3e7b9a992a3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
