Todd Lipcon has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6924/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS1, Line 450: for (int i = 0; i < 1000; i++) { : if (workload.rows_inserted() >= rows_target) break; : SleepFor(MonoDelta::FromMilliseconds(10)); : } > The client should respect KuduSession.setTimeout() and I believe that is th One future thing we can consider is actually triggering a second attempt on a different replica before we've timed out on the first replica. Given we now have the idempotent request tracker thing in place, it may be safe to do so (if in fact both RPCs go through, they'll still execute exactly once). This is especially true on the metadata read requests from the master which are inherently idempotent (being read-only). That said, we don't have the right machinery in place to do it today, just wanted to mention it so it's in the back of your minds :) http://gerrit.cloudera.org:8080/#/c/6924/1/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 217: server_picker_->MarkServerFailed(server, result.status); > OK now I remember the issue I had when looking at this issue previously. I In the case of a timeout, that still might be a good idea, no? It's not 100% clear. -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfcece485e4053d921ffdc865612b3e7b9a992a3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
