Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/integration-tests/client_failover-itest.cc File src/kudu/integration-tests/client_failover-itest.cc: PS4, Line 252: tserver::TabletServerIntegrationTestBase > does FindTabletLeader() do what you need? Excellent -- it looks like exactly what I need. Thanks! http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 167: // A note regarding ServerPicker::MarkServerFailed() calls in this method: > Isn't that just an abstract base class with no other implementations? Can w Probably, yes. However, I would prefer to do that in a separate changelist and involve more people in discussing that. My concern is that we might be missing something looking only at this context. PS4, Line 195: MarkServerFailed > Maybe the confusion we've had about this is that the abstraction here is to I think we can address that separately -- my current priority to have the bug fixed. By my experience, discussing such things usually leads to many iterations with lot of bike-shedding, unfortunately. What do you think if I file a separate JIRA item to track this and we leave this as-is in the current patchset? -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfcece485e4053d921ffdc865612b3e7b9a992a3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
