Andrew Wong has posted comments on this change. Change subject: util: add fault injection of EIOs ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6881/12//COMMIT_MSG Commit Message: Line 10: a flag-specified glob pattern indicating which paths should fail > What made you decide to use globbing instead of regexes? I don't have an op It seems more natural since we're dealing with paths. Regex is definitely more flexible, but I'm not sure the flexibility is needed (at most we'd need to specify multiple paths, which can be done by comma-separating, which I've included in this patch). One change that would've been needed for regex was the functionality to escape characters for regex (e.g. to match a literal path). This could've been done by bringing in QuoteMeta (LOC 475 https://github.com/google/re2/blob/master/re2/re2.cc), but globbing seemed more elegant. http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 150: TAG_FLAG(env_inject_eio, hidden); > As of PS12 I see still see both env_inject_io_error and env_inject_eio. Are Done, and updated block_manager-test to make use of it http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/fault_injection.h File src/kudu/util/fault_injection.h: Line 46: // Note that 'status_expr' is evaluated even if 'fraction_flag' is zero. > Are you still working on this? Done, I took out the DoMaybeReturnFailure code since it's unused after the change. -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
