Dan Burkert has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: Line 419: ASSERT_EQ(SequenceToken::kInvalidSlotIndex, t2.slot_index_); > I'm not seeing why; can you elaborate? woops, I misunderstood the test -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
