Alexey Serbin has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/6874/6/src/kudu/util/debug-util.h File src/kudu/util/debug-util.h: PS6, Line 105: { add 'const' specifier? http://gerrit.cloudera.org:8080/#/c/6874/6/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: PS6, Line 333: DEALLOCATED AVAILABLE PS6, Line 344: DEALLOCATED AVAILABLE Line 435: SequenceSlot* slot = slot_index ? slots_[*slot_index].get() : nullptr; paranoid nit: does it make sense to add something like DASSERT(!slot_index || *slot_index < slots_.size()); ? PS6, Line 708: } Does it make sense to add CHECK(!task) for the case new_state == ASSIGNED? http://gerrit.cloudera.org:8080/#/c/6874/6/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: PS6, Line 177: ; add 'const' specifier? Line 398: void CheckStateTransition(State new_state, const boost::optional<Task>& task); add 'const' specifier? -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
