Adar Dembo has posted comments on this change.

Change subject: Add basic Hive MetaStore client
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7053/8/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 714:     -DWITH_BOOSTTHREADS=OFF \
> Yes, we may need to go back and turn this on later, but for now it's simple
Why "may need to"? Now that we're encrypting server-to-server communication, 
isn't encryption of traffic to HMS a requirement?

Anyway I'm fine with deferring it to later, but we should probably put a big 
red sign up somewhere. Maybe a JIRA.


-- 
To view, visit http://gerrit.cloudera.org:8080/7053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to