Alexey Serbin has posted comments on this change. Change subject: Add basic Hive MetaStore client ......................................................................
Patch Set 10: (6 comments) Just skimmed through -- will take another look tomorrow. Overall looks good! http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/CMakeLists.txt File src/kudu/hms/CMakeLists.txt: PS10, Line 47: COMMAND ln -sf : "${JAVA_HOME}" : "${EXECUTABLE_OUTPUT_PATH}/java-home" As I understand, ${JAVA_HOME} is a directory. What happens if this command run twice? Wouldn't it be a just another link in java-home subdir? Is that true for the first two as well? If so, consider using 'ln -nsf' instead of 'ln -sf' http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: PS10, Line 26: #include <gflags/gflags.h> Is it needed in here? PS10, Line 49: SIGKILL Why not SIGTERM? http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/util/test_util.h File src/kudu/util/test_util.h: PS10, Line 112: // Attempts to find the path to the executable, searching the provided locations : // as well as the $PATH environment variable. : Status GetExecutablePath(const std::string& binary, : const std::vector<std::string>& search, : std::string* path) WARN_UNUSED_RESULT; : : // Waits for the subprocess to bind to any listening TCP port, and returns the port. : Status WaitForTcpBind(pid_t pid, uint16_t* port, MonoDelta timeout) WARN_UNUSED_RESULT; : : // Waits for the subprocess to bind to any listening UDP port, and returns the port. : Status WaitForUdpBind(pid_t pid, uint16_t* port, MonoDelta timeout) WARN_UNUSED_RESULT; Maybe, it's worth publishing it ((.e. moving those things from kerberos-specific files into the utils) as a separate changelist ? That way it would be easier to review and track changes in the changelog. http://gerrit.cloudera.org:8080/#/c/7053/10/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: PS10, Line 237: sf -nsf ? PS10, Line 242: sf -nsf ? -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
