Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7269
to review the following change.
Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
......................................................................
KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs
There's not much to say beyond what's already in the bug report.
To test, I created a 128 GB loopback-mounted xfs filesystem and ran the new
benchmark on it. I included the results below. I also ran the entire Kudu
test suite on that filesystem.
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags
Time spent writing 1073741824 bytes to file: real 0.538s user 0.006s
sys 0.533s
Time spent syncing file: real 8.142s user 0.002s sys 0.193s
Time spent punching first hole of size 10485760: real 0.131s user 0.000s
sys 0.130s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 0.007s user
0.004s sys 0.003s
$ TEST_TMPDIR=/data/8/adar/xfs/ bin/env-test \
--gtest_filter=*Benchmark* \
--never_fsync=false \
--unlock_unsafe_flags \
--unlock_experimental_flags \
--env_use_alternate_hole_punch_on_xfs=false
Time spent writing 1073741824 bytes to file: real 0.555s user 0.007s
sys 0.550s
Time spent syncing file: real 8.241s user 0.000s sys 0.219s
Time spent punching first hole of size 10485760: real 0.175s user 0.000s
sys 0.148s
Time spent syncing file: real 0.000s user 0.000s sys 0.000s
Time spent repunching 1000 holes of size 10485760: real 27.719s user
0.026s sys 0.029s
Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 104 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7269/1
--
To view, visit http://gerrit.cloudera.org:8080/7269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
