Adar Dembo has posted comments on this change. Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 83: // These struct and ioctl definitions were copied verbatim from xfsprogs. > Could the use-site be if-deff'd out on OS X instead of redeclaring the stru Todd sent this question over to ASF legal. Dan: unfortunately this isn't like the fallocate() definitions where they do exist in (some) Linux distribution headers and thus can be conditioned on macOS. I couldn't find these definitions in any standard headers; AFAICT they only exist in xfsprogs. PS2, Line 146: env_use_alternate_hole_punch_on_xfs > maybe instead of 'alternate' say 'ioctl'? Done -- To view, visit http://gerrit.cloudera.org:8080/7269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
