Todd Lipcon has posted comments on this change. Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs ......................................................................
Patch Set 2: (2 comments) Patch seems fine but I have a licensing worry that may be a blocker http://gerrit.cloudera.org:8080/#/c/7269/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 83: // These struct and ioctl definitions were copied verbatim from xfsprogs. do we have a licensing issue here? This is probably one of those gray areas, but we should be careful because the original header seems to carry an LGPL license notice. I tried googling a bit to find precedent within the ASF but perhaps we should consult legal? PS2, Line 146: env_use_alternate_hole_punch_on_xfs maybe instead of 'alternate' say 'ioctl'? -- To view, visit http://gerrit.cloudera.org:8080/7269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
