Todd Lipcon has posted comments on this change. Change subject: KUDU-2052: use XFS_IOC_UNRESVSP64 ioctl to punch holes on xfs ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/7269/4/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: PS4, Line 367: for (int i = 0; i < kOneMb; i += sizeof(uint32)) { : *reinterpret_cast<uint32_t*>(&scratch[i]) = r.Next(); : } nit: could use RandomString(scratch, arraysize(scratch), &r); (from random_util.h) http://gerrit.cloudera.org:8080/#/c/7269/4/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 805: // fallocate() syscall. Maybe a short comment explaining that this works around a perf issue on el6? (on newer systems the two are identical, so someone might not understand why we went through the effort to do this) Line 966: WARN_NOT_OK(s, "failed to check if file is on xfs"); should we do a FIRST_K type thing here? -- To view, visit http://gerrit.cloudera.org:8080/7269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3f5478729594f2a7e4e441905995b6f5d207d51 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
