Mike Percy has posted comments on this change. Change subject: mini_cluster: support multiple data dirs ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/7211/11/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: PS11, Line 59: data$0 I think it would be more readable as "data-$0" http://gerrit.cloudera.org:8080/#/c/7211/11/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: PS11, Line 65: "data$0 I know this is subjective but I think this would be a little more readable when doing an "ls" as "data-$0" -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
