Mike Percy has posted comments on this change. Change subject: WIP: consensus_peers: schedule raft heartbeats through messenger ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7331/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 141: FLAGS_raft_heartbeat_interval_ms); nit: can fit on one line Line 275: // We randomize the subsequent wait timeout between period/2 and period. What do you think about building in jitter on every scheduling? particularly for "cold" tablets they will never get additional jitter beyond whatever their timing was when the tablets were first created / opened. http://gerrit.cloudera.org:8080/#/c/7331/1/src/kudu/consensus/consensus_peers.h File src/kudu/consensus/consensus_peers.h: Line 153: void ScheduleHeartbeatCb(const Status& status); Mention in the docs that this is effectively a recursive call -- To view, visit http://gerrit.cloudera.org:8080/7331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8e09fe02dd32885ef0cf644cb093b1c8e6afb8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
