Adar Dembo has posted comments on this change. Change subject: WIP: consensus_peers: schedule raft heartbeats through messenger ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7331/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 108: Peer::Peer(const RaftPeerPB& peer_pb, > warning: pass by value and use std::move [modernize-pass-by-value] Done Line 141: FLAGS_raft_heartbeat_interval_ms); > nit: can fit on one line I like wrapping at 80 characters and this is 85, but done. Line 275: // We randomize the subsequent wait timeout between period/2 and period. > What do you think about building in jitter on every scheduling? particularl Sure, why not. http://gerrit.cloudera.org:8080/#/c/7331/1/src/kudu/consensus/consensus_peers.h File src/kudu/consensus/consensus_peers.h: Line 153: void ScheduleHeartbeatCb(const Status& status); > Mention in the docs that this is effectively a recursive call Done -- To view, visit http://gerrit.cloudera.org:8080/7331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8e09fe02dd32885ef0cf644cb093b1c8e6afb8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
