Adar Dembo has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7331/3/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 108: Peer::Peer(RaftPeerPB peer_pb, > warning: pass by value and use std::move [modernize-pass-by-value] Done Line 117: peer_pb_(peer_pb), > warning: parameter 'peer_pb' is passed by value and only copied once; consi Done -- To view, visit http://gerrit.cloudera.org:8080/7331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8e09fe02dd32885ef0cf644cb093b1c8e6afb8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
