Adar Dembo has posted comments on this change.

Change subject: consensus_peers: schedule raft heartbeats through messenger
......................................................................


Patch Set 4:

Thanks for doing this.

 > Any idea why the resulting heartbeat rate is higher than before
 > with this patch?

I think it's because I followed Mike's suggestion to add jitter to all 
heartbeats, not just ones with data. The existing approach was to convert a 
full period heartbeat into Uniform(period/2, period) and I preserved it 
faithfully, so it makes sense that there are net more heartbeats than there 
were before.

-- 
To view, visit http://gerrit.cloudera.org:8080/7331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8e09fe02dd32885ef0cf644cb093b1c8e6afb8
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to