Todd Lipcon has posted comments on this change.

Change subject: consensus_peers: schedule raft heartbeats through messenger
......................................................................


Patch Set 4:

Indeed it looks like the behavior is better with the patch.

Without the patch: https://i.imgur.com/ljDJTlf.png

With the patch: https://i.imgur.com/5Rlxoor.png

So the jitter is definitely beneficial.

Do you think we should change it so the jitter is still centered around the 
configured heartbeat? Or do you think it's OK that we're increasing the 
heartbeat frequency with this patch?

-- 
To view, visit http://gerrit.cloudera.org:8080/7331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8e09fe02dd32885ef0cf644cb093b1c8e6afb8
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to