Adar Dembo has posted comments on this change.

Change subject: [tools] Add a 'kudu tablet relocate' tool
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7444/4/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

Line 215:   for (int i = 0; i < num_moves; i++) {
> num_moves = 1 about 3 seconds though can vary a bit; with num_moves = 3 it'
OK. The slow vs. non-slow division makes sense.


http://gerrit.cloudera.org:8080/#/c/7444/6/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:

Line 392:                                leader_uuid, leader_hp,
Nit: indentation.


-- 
To view, visit http://gerrit.cloudera.org:8080/7444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7a7243333ba6e6a3d6fce96b220224d6e38a84
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to