Adar Dembo has posted comments on this change. Change subject: [tools] Add a 'kudu tablet relocate' tool ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7444/6/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: Line 149: return s.CloneAndPrepend("timed out with ksck errors remaining: last error"); > nit: We usually capitalize the first word of a Status message Actually, we're trying not to do that in new code since we're chaining statuses more and more using RETURN_NOT_OK_PREPEND, Status::CloneAndPrepend, etc. All of these chaining operations use colons as delimiters, and so the resulting message reads more cleanly if it's "unable to foo: bar failed because: baz failed". Ideally we'd capitalize the first letter of the first message (and perhaps add a period to the last message) but it's tough to tell which is first and which is last. -- To view, visit http://gerrit.cloudera.org:8080/7444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7a7243333ba6e6a3d6fce96b220224d6e38a84 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
