Mike Percy has posted comments on this change.

Change subject: [tools] Add a 'kudu tablet relocate' tool
......................................................................


Patch Set 8:

(4 comments)

looks good, just a couple minor things

http://gerrit.cloudera.org:8080/#/c/7444/8/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:

PS8, Line 458: warning
error


PS8, Line 460: WARNING
seems like this should be ERROR


PS8, Line 463: error
warning


http://gerrit.cloudera.org:8080/#/c/7444/6/src/kudu/tools/tool_action_tablet.cc
File src/kudu/tools/tool_action_tablet.cc:

Line 149:   return s.CloneAndPrepend("timed out with ksck errors remaining: 
last error");
> Thanks Adar.
+1


-- 
To view, visit http://gerrit.cloudera.org:8080/7444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7a7243333ba6e6a3d6fce96b220224d6e38a84
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to