Adar Dembo has posted comments on this change. Change subject: [tools] Add a 'kudu tablet relocate' tool ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7444/7/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: Line 83: static Status GetRpcAddressForTS(const client::sp::shared_ptr<KuduClient>& client, These functions are in an anonymous namespace, so they needn't be declared static. I think clang-tidy will flag that. Line 436: const string move_extra_desc = "The replica relocation tool effectively " Maybe "relocation" is no longer the word you want to use in this string? -- To view, visit http://gerrit.cloudera.org:8080/7444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7a7243333ba6e6a3d6fce96b220224d6e38a84 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
