Todd Lipcon has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use ......................................................................
Patch Set 3: (2 comments) any idea what the incremental compilation time cost is for thirdparty on this? http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: PS3, Line 55: local URL_PREFIX=$3 : if [ -z "$URL_PREFIX" ]; then : URL_PREFIX="${CLOUDFRONT_URL_PREFIX}" : fi is this used? http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/vars.sh File thirdparty/vars.sh: PS3, Line 148: IWYU_NAME=llvm-$LLVM_VERSION.src : IWYU_SOURCE=$TP_SOURCE_DIR/$IWYU_NAME are these actually used, then? -- To view, visit http://gerrit.cloudera.org:8080/7593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041ad9e4bbff410f1760c7abd8cd173e5e9cc564 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
