Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7749

to look at the new patch set (#3).

Change subject: KUDU-2095 - Add `keepAlive` method to Java API
......................................................................

KUDU-2095 - Add `keepAlive` method to Java API

- Adds keepAlive methods to sync and async clients
- Methods return a (Deferred) Status object

Where possible the behavior mimics the C++ client. The C++ client has extra
properties that keep track of the last response, however adding this to the Java
client looked invasive and I did not implement it.

I added one test in TestKuduClient that also mirrors the C++. The test
runs in a KuduMiniCluster so ttl could be lowered. This means two
MiniClusters are running at the same time but it seems to cause no
problems and is cleaner than making a new test class. Even though the
TTL is low the time it takes for the scanner to be garbage collected is
long and the test takes ~10 seconds. The C++ client code comments that
the garbage collection of scanners runs each 50ms which is a lot faster
than it is running here but was unable to find a flag to lower it other
than scanner_ttl.

Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
5 files changed, 156 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7749/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Kudu Jenkins

Reply via email to