[email protected] has posted comments on this change. Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7749/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 839: if (tablet == null) { > I still have some work to do here I think Maybe not, I think the behavior is correct. The other client has ``` // If there is no scanner to keep alive, we still return Status::OK(). if (!last_response_.IsInitialized() || !last_response_.has_more_results() || !next_req_.has_scanner_id()) { return Status::OK(); } ``` And I think I cover all of those cases -- To view, visit http://gerrit.cloudera.org:8080/7749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
