[email protected] has posted comments on this change. Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7749/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 845: final ReplicaSelection replicaSelection = scanner.getReplicaSelection(); I think this is better. A scanner would fail with ReplicaSelection.CLOSEST_REPLICA. Now that passes but since CLOSEST_REPLICA could return a random replica I don't know that this is exactly correct. http://gerrit.cloudera.org:8080/#/c/7749/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 843: final KuduRpc<Status> keepAliveRequest = scanner.getKeepAliveRequest(); I think this is better, but since ReplicaSelection.CLOSEST_REPLICA can return a random replica if they're equidistant I'm not sure how I'd know which exact replica has the scanner. It seems to rely on the order a java.util.Map iterates values in RemoteTablet. http://gerrit.cloudera.org:8080/#/c/7749/6/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java: Line 62: * Keep the current remote scanner alive. I took the long docs from C++ for the public methods http://gerrit.cloudera.org:8080/#/c/7749/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: Line 60: @BeforeClass Is this a good idea to change the timeouts for all tests? Doesn't seem to cause problems for me but I don't want to cause any flakiness -- To view, visit http://gerrit.cloudera.org:8080/7749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
