[email protected] has posted comments on this change. Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API ......................................................................
Patch Set 5: (3 comments) Notice I removed the public method from AsyncKuduClient, keepAlive can be called from the scanner only, not from the client with the scanner as an arg http://gerrit.cloudera.org:8080/#/c/7749/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 843: final KuduRpc<Status> keepAliveRequest = scanner.getKeepAliveRequest(); > this seems relatively suspicious. I see you copied it from 'close' above, b Right the replica selected was always the master and it failed when I set the scanner ReplicaSelection.CLOSEST_REPLICA. I then tried to use the scanner's ReplicaSelection and keepAlive works: ``` final ReplicaSelection replicaSelection = scanner.getReplicaSelection(); final ServerInfo info = tablet.getReplicaSelectedServerInfo(replicaSelection); ``` but CLOSEST_REPLICAs documentation says it could choose a random replica. I don't know if this is actually correct or if it just happens to choose the same replica in my test. http://gerrit.cloudera.org:8080/#/c/7749/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: Line 45: import org.apache.yetus.audience.InterfaceAudience; Will remove http://gerrit.cloudera.org:8080/#/c/7749/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: Line 60: @BeforeClass This runs ok and is like -- To view, visit http://gerrit.cloudera.org:8080/7749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba647e7b5ed4ee8d223d387b6656d3fb02c41713 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
