Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7701/1//COMMIT_MSG Commit Message: PS1, Line 9: into > Nit: into Done PS1, Line 11: sync > synced Done PS1, Line 13: to keep track of block data disk synchronization count. : : I did a m > We talked about this in person a little bit, but could you provide more det Done http://gerrit.cloudera.org:8080/#/c/7701/1/src/kudu/tserver/tablet_copy_client-test.cc File src/kudu/tserver/tablet_copy_client-test.cc: Line 196: > I like this idea Done http://gerrit.cloudera.org:8080/#/c/7701/1/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: Line 27: #include "kudu/gutil/macros.h" > Why do you need this? Can't you forward declare BlockTransaction? Done PS1, Line 164: ogging > belonging Done Line 177: // Download a single block. > Update this (and maybe the entire comment). Done -- To view, visit http://gerrit.cloudera.org:8080/7701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7534699f589c7060ffe32d7ac67546476cf21e76 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
