Adar Dembo has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7701/1//COMMIT_MSG Commit Message: PS1, Line 13: to keep track of block data disk synchronization count. : : I did a m > Done What about the disk setup? How many disks did each tserver have? Did they share disks? http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1870: s = env_->SyncDir(container.data_dir()->dir()); Should also track this, no? http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/tserver/tablet_copy_client-test.cc File src/kudu/tserver/tablet_copy_client-test.cc: Line 91: MetricRegistry registry; I'm surprised it's OK for the registry to go out of scope and be destroyed while the MetricEntity is still alive. http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: PS5, Line 178: Data block is opened with options. I don't understand what this remnant is trying to convey. -- To view, visit http://gerrit.cloudera.org:8080/7701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7534699f589c7060ffe32d7ac67546476cf21e76 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
