Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: PS5, Line 390: > See comment in log_block_manager.cc regarding this metric, and below I think this one is in the right place, only updated for SyncMetadata below. http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 886: RETURN_NOT_OK(SyncData()); > hmm. Should these metric increments happen inside SyncData() so they remain Makes sense. Updated. Line 1870: MakeContainerAvailableUnlocked(container); > Should also track this, no? Done http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/tserver/tablet_copy_client-test.cc File src/kudu/tserver/tablet_copy_client-test.cc: Line 91: metric_entity_ = METRIC_ENTITY_server.Instantiate(&metric_registry_, "test"); > I'm surprised it's OK for the registry to go out of scope and be destroyed Right... Thanks for catching it. http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: PS5, Line 178: Data block is opened with new ID. > I don't understand what this remnant is trying to convey. Yeah, actually I do not quite follow the original comment. But let me try to rephrase it based on my understanding. -- To view, visit http://gerrit.cloudera.org:8080/7701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7534699f589c7060ffe32d7ac67546476cf21e76 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
