Mike Percy has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: PS5, Line 390: See comment in log_block_manager.cc regarding this metric, and below http://gerrit.cloudera.org:8080/#/c/7701/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 886: if (metrics_) metrics_->generic_metrics.total_disk_sync->Increment(); hmm. Should these metric increments happen inside SyncData() so they remain consistent with FLAGS_enable_data_block_fsync? Here and below -- To view, visit http://gerrit.cloudera.org:8080/7701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7534699f589c7060ffe32d7ac67546476cf21e76 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
