Alexey Serbin has posted comments on this change.

Change subject: tablet copy: Allow voting from crashed initial tablet copies
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

BTW, what was the setting for --stress_cpu_threads for that 200x run?  
Yesterday I ran delete_table-itest and found that it failed with 1/500 ratio at 
AddServer(), so I posted a fix (with similar workaround) for  that.

http://gerrit.cloudera.org:8080/#/c/7961/3/src/kudu/integration-tests/tablet_copy-itest.cc
File src/kudu/integration-tests/tablet_copy-itest.cc:

PS3, Line 1187:   LOG(INFO) << "Restarting tablet servers. New replica TS UUID: 
" << new_replica_uuid
              :             << ", tablet data state: "
              :             << 
tablet::TabletDataState_Name(superblock.tablet_data_state())
              :             << ", last-logged opid: " << 
superblock.tombstone_last_logged_opid();
> I understand wanting to keep the logs short, but that's a lot to ask for th
SGTM -- thank you for the clarification.


-- 
To view, visit http://gerrit.cloudera.org:8080/7961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc9cecac701c24ebe05759adbbb1fbe2b140506
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to