Mike Percy has submitted this change and it was merged. Change subject: tablet copy: Allow voting from crashed initial tablet copies ......................................................................
tablet copy: Allow voting from crashed initial tablet copies The change in c35e4f0093dcdec625d1f647924d854c7bc9f3de missed an important case, which is when the target tablet server in a tablet copy operation crashes while in the middle of a tablet copy. In that case, the 'tombstone_last_logged_opid' of 1.0 was not persisted in the superblock. This manifested as a very flaky TabletCopyITest.TestTabletCopyNewReplicaFailureCanVote test, which would fail about 15% of the time. With the change in this patch, that test now passes reliably: http://dist-test.cloudera.org/job?job_id=mpercy.1504654266.31446 Change-Id: Idbc9cecac701c24ebe05759adbbb1fbe2b140506 Reviewed-on: http://gerrit.cloudera.org:8080/7961 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/consensus/consensus-test-util.h M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_copy_client.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 11 files changed, 182 insertions(+), 35 deletions(-) Approvals: Todd Lipcon: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc9cecac701c24ebe05759adbbb1fbe2b140506 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
