Alexey Serbin has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8066/1/src/kudu/client/client.cc File src/kudu/client/client.cc: PS1, Line 1145: CHECK(resp.has_table_id()); Would it make sense to use the name of the table passed into the constructor of the object in that case (KuduTableAlterer::KuduTableAlterer(KuduClient* client, const string& name)) instead of crashing? http://gerrit.cloudera.org:8080/#/c/8066/1/src/kudu/integration-tests/master_failover-itest.cc File src/kudu/integration-tests/master_failover-itest.cc: PS1, Line 205: MonoTime now; : do { : bool create_in_progress; : ASSERT_OK(client_->IsCreateTableInProgress(kTableName, &create_in_progress)); : if (!create_in_progress) { : break; : } : SleepFor(MonoDelta::FromMilliseconds(100)); : now = MonoTime::Now(); : } while (now < deadline); : ASSERT_TRUE(now < deadline) << "Timed out waiting for CreateTable to finish"; Could ASSERT_EVENTUALLY() fit here? -- To view, visit http://gerrit.cloudera.org:8080/8066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
