Alexey Serbin has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them ......................................................................
Patch Set 2: Code-Review+1 (1 comment) LGTM, but perhaps Todd or JD need to approve the introduced 'incompatibility' with pre-0.10 servers. http://gerrit.cloudera.org:8080/#/c/8066/1/src/kudu/client/client.cc File src/kudu/client/client.cc: PS1, Line 1145: CHECK(resp.has_table_id()); > We could, but the version of Kudu that doesn't return a table ID in AlterTa SGTM -- To view, visit http://gerrit.cloudera.org:8080/8066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
