Alexey Serbin has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8066/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: PS2, Line 116: table_identifier > maybe 'table_ref' to make it less confusing? ie a 'reference' is either an Nit: another option might be introducing a special type TableIdentifier, which would have methods HasUuid(), uuid(), HasName(), name(). The TableIdentificationMode would be needed only for constructor or it's possible to drop it at all , adding SetName() and SetUuid() methods. -- To view, visit http://gerrit.cloudera.org:8080/8066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
