Todd Lipcon has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8066/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: PS2, Line 116: table_identifier > nit: use table_id like in the method below. maybe 'table_ref' to make it less confusing? ie a 'reference' is either an ID or a name. Or maybe table_specifier http://gerrit.cloudera.org:8080/#/c/8066/2/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 1145: CHECK(resp.has_table_id()); why not just return some kind of bad status here indicating that probably the client is connecting to a very old server? I think that's preferable to crashing, in the context of a client which might be embedded in some other app. At the very least let's add a more useful CHECK message -- To view, visit http://gerrit.cloudera.org:8080/8066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
