Adar Dembo has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8066/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: PS3, Line 465: *req.mutable_table() = std::move(table); > iirc you can use mutable_table()->Swap(&table) here I think I'm just going to ignore these warnings. I can't reproduce them locally with `make tidy`, and I verified in a quick unit test that *foo.mutable_bar() = std::move(bar) triggers a real move (I added abort() to the generated move constructor/assignment operator and the test crashed). -- To view, visit http://gerrit.cloudera.org:8080/8066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
