Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7656/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 170: class BlockDeletionTransaction : public RefCountedThreadSafe<BlockDeletionTransaction> { > Sure, just curious I saw in our contribution page (https://kudu.apache.org/ Yeah, I think Dan mentioned this to me the other day. The big minus against shared_ptr (two allocations) is no longer true with C++11 and std::make_shared. Given that shared_ptr is usable with weak_ptr (and thus allows for more flexible object lifetimes, especially with lambdas), I think that's enough to favor it over scoped_refptr in the general case. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
