Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7656/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 170: class BlockDeletionTransaction : public RefCountedThreadSafe<BlockDeletionTransaction> { > I see, thanks! Would you mind I make it shard_ptr in next patch. After thin Won't you need some sort of shared ownership in order to allow BlockDeletionTransaction to be incorporated into LogBlockManager::DeleteBlock though? -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
