Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7656/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 170: // used to specify directories based on block type (e.g. to prefer bloom block > Won't you need some sort of shared ownership in order to allow BlockDeletio Yes, but the main reason for doing so is to improve performance by coalescing hole punching belongs to the same container (Otherwise, we do not need to make it a shared ownership). Given we do not want to 'change any deletion semantics or improve performance' in this patch, I feel we can move this logic into next patch. But I am open to either options (either put it in this patch or next one), if you have a stronger preference. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
