Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7656/7/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 284: BlockManager* bm = created_blocks_[0]->block_manager(); > Since BlockDeletionTransaction can't infer the BlockManager from the delete Done Line 309: void AddDeletedBlock(const BlockId& block) { > BlockIds are small (64-bits each) so it's preferred to pass them by value a Done PS7, Line 317: // Returns the list of IDs, among the given blocks IDs, of block that can be : // successfully deleted. > Why doesn't this have the same signature as CommitCreatedBlocks? Done Line 324: WARN_NOT_OK(s, strings::Substitute("Could not delete block $0", block.ToString())); > Seems like an unusual place for a warning. I'd suggest an alternative: Sure, but I would like to add a output parameter to include which blocks are successfully deleted. In case like TabletMetadata::DeleteOrphanedBlocks, may need information as such. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
