Todd Lipcon has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consensus/consensus_meta.cc File src/kudu/consensus/consensus_meta.cc: Line 276: if (PREDICT_FALSE(FLAGS_cmeta_inject_latency_on_flush_ms > 0)) { you may need to ANNOTATE_UNPROTECTED_READ this here and below http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS3, Line 125: be allowed at a time it doesn't actually serialize the whole election, right? it just serializes the _starting_ of elections? I think its' worth noting somewhere that you are mostly trying to avoid the case where the consensus lock is held and thus even the _starting_ of the election is quite slow -- To view, visit http://gerrit.cloudera.org:8080/8107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeaf99ce57f7d5cd01a6c786c178567a98438ced Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
